Add datetime.datetime type to commit_date and author_date#1501
Merged
Byron merged 1 commit intogitpython-developers:mainfrom Oct 14, 2022
SergeantMenacingGarlic:date_types
Merged
Add datetime.datetime type to commit_date and author_date#1501Byron merged 1 commit intogitpython-developers:mainfrom SergeantMenacingGarlic:date_types
Byron merged 1 commit intogitpython-developers:mainfrom
SergeantMenacingGarlic:date_types
Conversation
Member
|
Thanks a lot, much appreciated! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update type hints to match acceptable date types.
Passing a
datetime.datetimeobject forauthor_dateorcommit_datecauses a mypy type error, these dates are passed toparse_dateingit.objects.util, which does accept adatetime.datetimeobject.